membuffer: support staging & checkpoint for ART #1465
Conversation
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
ti-chi-bot
bot
added
dco-signoff: yes
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: you06 <[email protected]>
|
|
||
| func (t *ART) truncate(snap *arena.MemDBCheckpoint) { | ||
| panic("unimplemented") | ||
| cp := &t.stages[h-1] |
There was a problem hiding this comment.
Is it possible that len(stages)=0 and h=0? Shall we test that?
There was a problem hiding this comment.
h == 0 means staging is not support in TiDB, I think we can just return for this case.
I'll add test for it.
| panic("unimplemented") | ||
| } | ||
| if h > len(t.stages) { | ||
| return |
There was a problem hiding this comment.
Not directly related to this change, but I wonder whether there are such usages...
There was a problem hiding this comment.
TiDB always call defer memBuffer.Clean after a group of mutations (even memBuffer.Release is already invoked), so this case is expected and valid.
func addRecord() {
sh := memBuffer.Staging() // sh == 2, len(stages) == 2
defer memBuffer.Cleanup(sh) // sh == 2, len(stages) == 1
...
memBuffer.Release(sh) // len(stages) == 1 after this call
}
internal/unionstore/art/art.go
Outdated
| @@ -392,51 +393,89 @@ func (t *ART) Size() int { | |||
| } | |||
|
|
|||
| func (t *ART) checkpoint() arena.MemDBCheckpoint { | |||
| panic("unimplemented") | |||
| return t.allocator.vlogAllocator.Checkpoint() | |||
| } | |||
|
|
|||
| func (t *ART) RevertNode(hdr *arena.MemdbVlogHdr) { | |||
There was a problem hiding this comment.
Is "RevertVLogEntry" or something similar a more appropriate name? RevertNode looks like we are deleting the node.
There was a problem hiding this comment.
Rename it to RevertVAddr.
Signed-off-by: you06 <[email protected]>
ti-chi-bot
bot
added
size/XL
Signed-off-by: you06 <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, ekexium The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
ref pingcap/tidb#55287
This PR implements
Staging/Release/CleanupandCheckpoint/RevertToCheckpointfor ART, the behavior is exactly same with RBT.