membuffer: support iterator for ART #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
dco-signoff: yes
cfzjywxk
approved these changes
Sep 24, 2024
| @@ -928,6 +955,7 @@ func testMemDBCheckpoint(t *testing.T, buffer MemBuffer) { | |||
|
|
|||
| func TestBufferLimit(t *testing.T) { | |||
| testBufferLimit(t, newRbtDBWithContext()) | |||
| testBufferLimit(t, newArtDBWithContext()) | |||
| } | |||
|
|
|||
| func testBufferLimit(t *testing.T, buffer MemBuffer) { | |||
There was a problem hiding this comment.
Is all the previous memdb test executed for both art and rbt implementations by now?
There was a problem hiding this comment.
Snapshot read is not supported yet, all the other tests are running for both art and rbt.
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
you06-pingcap
force-pushed
the
memdb/art-iterator
branch
from
5593212
to
e2b8216
Compare
ekexium
approved these changes
Sep 24, 2024
| inner: &baseIter{ | ||
| allocator: &t.allocator, | ||
| }, | ||
| currAddr: arena.BadAddr, // the default value of currAddr is not equal to any valid address |
There was a problem hiding this comment.
Can we document how BadAddr is different from NullAddr?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, ekexium The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref pingcap/tidb#55287
This PR implements
Iteratorfor ART.