refactor: Make prometheus features push and process optional to get rid of openssl
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Xuanwo
changed the title
push and process optional to get rid of openssl
bxq2011hust
pushed a commit
to FISCO-BCOS/tikv-client-rust
that referenced
this pull request
Mar 19, 2024
…et rid of openssl (tikv#433) * refactor: Make prometheus deps optional Signed-off-by: Xuanwo <[email protected]> * Remove push and process Signed-off-by: Xuanwo <[email protected]> --------- Signed-off-by: Xuanwo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #407 in a compatible way:
- Users enabledefaultfeature still enablesprometheus/process.- Users disabledefaultfeature can enable featureprometheusbased on their needs.prometheusis so deep in the tikv-client's code, we can't remove it entirely. This PR changes it goal to makepushandprocessoptional.