Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving SyncRegions to another gRPC service #1276

Open
overvenus opened this issue Oct 17, 2018 · 1 comment
Open

Consider moving SyncRegions to another gRPC service #1276

overvenus opened this issue Oct 17, 2018 · 1 comment
Assignees
Labels
status/discussion-wanted The issue needs to be discussed.

Comments

@overvenus
Copy link
Member

Currently, SyncRegions is part of PD service, but it is for internal use only. To avoid pollute client APIs, please consider moving it to another gRPC service.

Cc #1237

@disksing
Copy link
Contributor

@overvenus I have a different opinion on this issue. Firstly it’s hard to say that it pollutes the client -- if you don't need it, you just don't call the method. The generated client won't force you to write any extra code to make it work. Secondly, this interface does not necessarily have to be used only internally by the PD. For example, third-party components can also use this method to synchronize all region metas from PD, which could be used for tasks like external scheduling or data analysis in the future.

@rleungx rleungx added the status/discussion-wanted The issue needs to be discussed. label Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/discussion-wanted The issue needs to be discussed.
Projects
None yet
Development

No branches or pull requests

4 participants