Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider BatchRegionHeartbeat #1488

Open
Tracked by #5648
overvenus opened this issue Apr 1, 2019 · 1 comment
Open
Tracked by #5648

Consider BatchRegionHeartbeat #1488

overvenus opened this issue Apr 1, 2019 · 1 comment
Labels
component/api HTTP API. type/enhancement The issue or PR belongs to an enhancement.

Comments

@overvenus
Copy link
Member

Currently, we use region heartbeat to do scheduling, one region one heartbeat stream. For every heartbeat stream, gRPC starts a goroutine, it works fine on small clusters, however, it may cause too much memory and CPU on large clusters. A straightforward solution is introducing a new rpc, BatchRegionHeart, it batches multiple region heartbeats into one message, I think it should save memory and CPU, and is a better way to do batch handling region heartbeats, #1448 .

@overvenus overvenus added type/enhancement The issue or PR belongs to an enhancement. component/api HTTP API. labels Apr 1, 2019
@bradyjoestar
Copy link
Contributor

bradyjoestar commented Apr 1, 2019

And currently leader broadcast regions info to follower,
could every follower get batch region's info from tikv store directly and cached it and its hash
and then wait a moment try to ask leader that have it seen this hash,this may release the pressure of leader too?:grin:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants