Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR#8608 may cause 10.0% performance regression in benchmarksql #8620

Open
owlsome2501 opened this issue Sep 12, 2024 · 2 comments
Open

PR#8608 may cause 10.0% performance regression in benchmarksql #8620

owlsome2501 opened this issue Sep 12, 2024 · 2 comments
Labels
needs-type Indicates an issue requires a type label.

Comments

@owlsome2501
Copy link

Bug Report

What did you do?

  1. Deploy a cluster with 3 TiDB and 3 Tikv.
  2. Run benchmark benchmarksql (benchmarksql-1k).

What did you expect to see?

No performance regression.

What did you see instead?

#8608 caused QPS regression 10.03% in benchmark benchmarksql (benchmarksql-1k) compared to baseline 60193.12.

description tidb tikv pd QPS
last success pingcap/tidb@a6c83ba tikv/tikv@d0c738a e27e55b 58850.23
first regression pingcap/tidb@a6c83ba tikv/tikv@d0c738a 8949567 54155.46

What version of PD are you using?

8949567

Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2024

There are no type labels on this issue. Please add an appropriate label by using the following command:

  • /type <type-name>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-type Indicates an issue requires a type label. label Sep 12, 2024
@rleungx
Copy link
Member

rleungx commented Sep 13, 2024

8949567 only updates the go module of tools which doesn't affect the PD. As for regression issue, we are retring to find the correct commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-type Indicates an issue requires a type label.
Projects
None yet
Development

No branches or pull requests

2 participants