You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I expected tilt down to shut down Tilt, not just delete resources that tilt up created
While I can see there may be use cases for tilt down not shutting down Tilt itself, I feel like most of these cases would be relegated to the use case of only running a group of services or cases where Tilt is being run in the foreground.
So I would propose one of the following:
tilt down detects whether tilt is running in the background or not. If it's in the background, kill Tilt itself. Otherwise, leave Tilt running until user hits CTRL+C.
tilt down (without services/groups) always both removes resources and kills Tilt itself
tilt down a would maintain current behavior & not kill Tilt, even if nothing remained (e.g. Tilt started with tilt < /dev/null > /dev/null up a & had been used to start Tilt)
Alternatively, tilt down always kills Tilt, regardless of whether you provided a service/group, and there could be a tilt down [service/group] --keepalive, though I don't see how this is better than conditional behavior based on whether service(s)/group(s) are provided
add a new tilt stop, tilt kill, or tilt shutdown command: effectively as a built-in alias for tilt down && pkill tilt
tilt up detects an idle Tilt using the same Tiltfile already running and reuses the port (this seems less than ideal, but has the smallest behavioral change)
Current Behavior
tilt down deletes resources, but leaves tilt running.
Steps to Reproduce
Run tilt up
In another terminal, run tilt down
Nothing is shown in terminal 1; Tilt continues to run even though there are no active resources
If you happened to be running Tilt in the background, the next time you use tilt up, you get an error about the port being in use
Context
tilt doctor Output
$ tilt doctor
Tilt: v0.33.11, built 2024-02-15
System: linux-amd64
---
Docker
- Host: unix:///var/run/docker.sock
- Server Version: 25.0.3
- API Version: 1.44
- Builder: 2
- Compose Version: v2.24.5-desktop.1
---
Kubernetes
- Env: eks
- Context: arn:aws:eks:us-west-2:**********
- Cluster Name: arn:aws:eks:us-west-2:**********
- Namespace: default
- Cluster Local Registry: none
---
About Your Use Case
As I mentioned in #4288 , because there's no daemon, there's also no tidy way to kill Tilt if you run it in the background via tilt < /dev/null > /dev/null up &
So if you do a mock daemon mode using the above, you have to do tilt down && pkill tilt which is quite tedious/verbose for a fairly common command.
The text was updated successfully, but these errors were encountered:
Expected Behavior
I expected
tilt down
to shut down Tilt, not just delete resources thattilt up
createdWhile I can see there may be use cases for
tilt down
not shutting down Tilt itself, I feel like most of these cases would be relegated to the use case of only running a group of services or cases whereTilt
is being run in the foreground.So I would propose one of the following:
tilt down
detects whethertilt
is running in the background or not. If it's in the background, kill Tilt itself. Otherwise, leave Tilt running until user hits CTRL+C.tilt down
(without services/groups) always both removes resources and kills Tilt itselftilt down a
would maintain current behavior & not kill Tilt, even if nothing remained (e.g. Tilt started withtilt < /dev/null > /dev/null up a &
had been used to start Tilt)tilt down
always kills Tilt, regardless of whether you provided a service/group, and there could be atilt down [service/group] --keepalive
, though I don't see how this is better than conditional behavior based on whether service(s)/group(s) are providedtilt stop
,tilt kill
, ortilt shutdown
command: effectively as a built-in alias fortilt down && pkill tilt
tilt up
detects an idleTilt
using the same Tiltfile already running and reuses the port (this seems less than ideal, but has the smallest behavioral change)Current Behavior
tilt down
deletes resources, but leaves tilt running.Steps to Reproduce
tilt up
tilt down
tilt up
, you get an error about the port being in useContext
tilt doctor
OutputAbout Your Use Case
As I mentioned in #4288 , because there's no daemon, there's also no tidy way to kill Tilt if you run it in the background via
tilt < /dev/null > /dev/null up &
So if you do a mock daemon mode using the above, you have to do
tilt down && pkill tilt
which is quite tedious/verbose for a fairly common command.The text was updated successfully, but these errors were encountered: