Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN-bound #22

Closed
timelyportfolio opened this issue Aug 14, 2016 · 10 comments
Closed

CRAN-bound #22

timelyportfolio opened this issue Aug 14, 2016 · 10 comments

Comments

@timelyportfolio
Copy link
Owner

sunburstR will be CRAN-bound by the end of the week 2016-08-20. I would love suggestions, improvements, examples to make it as good as possible before it is an official R package.

@voxnonecho
Copy link

voxnonecho commented Aug 17, 2016

Some suggestions:

Add more native options to play with legend / breadcrumb trail without having to rely on custom JS

  • Toggle on/off visibility of legend / breadcrumb trail (and the possibily to have legend showing by default - related to Have legend on as a default? #15)
  • Resize text (maybe a robust implementation of the idea in Big variable names overlapping in output #7 with tasks, but generalized for both legend and breadcrumb trail ?)
  • Provide the option to change text color in legend/breadcrumb trail (really helpful when providing custom colors through colors = list(domain = ..., range = ...)
  • Provide the option to change the path color on the R side (instead of having to edit .sunburst-chart path in sequences.css

Add options for labels on slices (see: http://stackoverflow.com/questions/29884995/adding-labels-to-d3-sunburst)

@timelyportfolio
Copy link
Owner Author

@voxnonecho all very nice suggestions. I'm afraid of adding too much before CRAN concerned that a not fully tested set of functionality will then linger as an official release. I'll add each item as a separate issue if no already out and tag for next release. Thanks so much for all the help!

@timelyportfolio
Copy link
Owner Author

on cran now https://cran.r-project.org/web/packages/sunburstR/index.html

@msusol
Copy link

msusol commented Feb 18, 2017

Is there a plan to upgrade to using d3.v4 ? The code currently uses 3.5.17 in d3r. I would like to help upgrade to 4.5 either here or in d3r

@timelyportfolio
Copy link
Owner Author

@msusol, I am eager to convert to d3v4, and the conversion is fairly straightforward (see Kerry Rodden's d3v4 version). However, I have not done yet because of other issues with d3 in global/window (see christophergandrud/networkD3#162) when combined with d3v3 htmlwidgets. Currently, I favor a standalone sunburst.js. I will try to sketch out this approach in the next one or two weeks.

Thanks so much for using and offering to help!

@msusol
Copy link

msusol commented Feb 21, 2017

what has been the uptake on using the package d3r? is this package just to facilitate htmlwidgets?

my need for this package is to generate the sunburst view in R, and knit to html for reports.

let me know how I can contribute in the short term.

@msusol
Copy link

msusol commented May 17, 2017

@timelyportfolio, any progress on making this a stand alone sunburst R package in d3 v4? I have had to delete the d3 v3 package as they (my employer) deprecated d3 v3.

@timelyportfolio
Copy link
Owner Author

Thanks @msusol for the ping. No plans yet. I estimate the effort will require about 15-20 hours of work. I recently left my full-time gig, so hours are sparse right now. I do intend to complete within the next couple of weeks/months.

@timelyportfolio
Copy link
Owner Author

timelyportfolio commented Jun 8, 2017

@msusol, the fantastic @cjyetman has offered to help with this, so see #36 to track progress. If you would like to participate, please let me know where you might like to chip in ;)

@timelyportfolio
Copy link
Owner Author

Also, going to close this issue down. Please reopen new issue, so that I can track. Thanks everyone for a great thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants