Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat aggregate rollup should interpolate aggregates #660

Closed
WireBaron opened this issue Dec 15, 2022 · 0 comments · Fixed by #683
Closed

Heartbeat aggregate rollup should interpolate aggregates #660

WireBaron opened this issue Dec 15, 2022 · 0 comments · Fixed by #683
Labels
bug Something isn't working

Comments

@WireBaron
Copy link
Contributor

Currently rollup just combines the intervals from each of its component aggregates, meaning a 5 minute heartbeat received three minutes before the end of an interval is only valid for three minutes. If the first heartbeat of the next interval arrives 30 seconds in, the aggregate will mark the 30 seconds prior as dead. We've solved this problem in the interpolate code, but we should also be correcting this automatically in rollup.

As part of fixing this, consider whether any of our other aggregates which support both interpolation and rollup also requires a similar fix.

@WireBaron WireBaron added the bug Something isn't working label Dec 15, 2022
@bors bors bot closed this as completed in 77fed05 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant