Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyterlab compatibility #94

Closed
rdeits opened this issue May 8, 2018 · 6 comments
Closed

Jupyterlab compatibility #94

rdeits opened this issue May 8, 2018 · 6 comments
Labels
up for grabs Fix requires a contribution (maintainer will not fix)

Comments

@rdeits
Copy link

rdeits commented May 8, 2018

ProfileView seems to display the profile correctly inside jupyterlab, but the function labels are missing and the panning, zooming, and mouseover effects don't work. I suspect this is because jupyterlab does not execute inline javascript.

@cossio
Copy link

cossio commented Nov 20, 2018

I am having the same issue.

In case someone else runs into this, in the meantime one can use PROFILEVIEW_USEGTK = true before using ProfileView to use the gtk interface (see Readme).

@timholy timholy added the up for grabs Fix requires a contribution (maintainer will not fix) label Nov 21, 2018
@timholy
Copy link
Owner

timholy commented Nov 21, 2018

Since I don't know javascript, fixing this is not on my agenda, but I would appreciate a pull request.

@jlumpe
Copy link

jlumpe commented Jan 8, 2019

As another workaround you can open the image in a new tab for the mouseover to work.

@cossio
Copy link

cossio commented Apr 20, 2019

@jlumpe How do you open it in a new tab?

@jlumpe
Copy link

jlumpe commented Apr 23, 2019

@cossio I can't remember exactly because this was three months ago and I haven't used it since then, but I think the output is an SVG image so (in Chrome at least) you can right click on it and select "Open image in new tab."

@timholy
Copy link
Owner

timholy commented Jan 22, 2020

Jupyter/SVG support moved to https://github.com/timholy/ProfileSVG.jl

@timholy timholy closed this as completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up for grabs Fix requires a contribution (maintainer will not fix)
Projects
None yet
Development

No branches or pull requests

4 participants