Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/approve command #39

Open
lemeurherve opened this issue Jul 22, 2022 · 4 comments
Open

/approve command #39

lemeurherve opened this issue Jul 22, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@lemeurherve
Copy link
Contributor

lemeurherve commented Jul 22, 2022

What feature do you want to see added?

If you've seen the diff and want to add label(s) and approve at the same time, such command could be useful, especially if auto-merge is enabled (maybe an option to this command?)
(Nice to have, low priority)

Upstream changes

No response

@lemeurherve lemeurherve added the enhancement New feature or request label Jul 22, 2022
@timja
Copy link
Owner

timja commented Jul 22, 2022

Could be done I think, would need to check the user has write access, but it would be approved by the bot not the user so I'm not sure how useful / great that would be.

@lemeurherve
Copy link
Contributor Author

lemeurherve commented Jul 22, 2022

would need to check the user has write access,

anyone can review...

it would be approved by the bot not the user

...but if it's the bot who's approving indeed it sets its own sort of issues. Good catch, need to think more about it.

I'll take a look at how the jenkins-x bot is doing it.

@timja
Copy link
Owner

timja commented Jul 22, 2022

I'll take a look at how the jenkins-x bot is doing it.

If it's anything like prow it adds labels and has rules on who has is allowed to do it.

@lemeurherve
Copy link
Contributor Author

Yeah, AFAIR it's a lighthouse bot, based on prow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants