From 0b926b9020d13b48e559fa1b83800b96cf6775cd Mon Sep 17 00:00:00 2001 From: Ben Kraft Date: Tue, 10 Jan 2023 09:08:23 -0800 Subject: [PATCH] Remove a layer of indirection for defaultRejectedValue Came across this while evaluating the library -- it looks like it was inadvertently doing `Promise.resolve(Promise.reject(err))`. That's mostly equivalent enough to `Promise.reject(err)`, but we might as well just do the simple thing. --- src/when.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/when.js b/src/when.js index 5dba5b3..36d1d7b 100644 --- a/src/when.js +++ b/src/when.js @@ -154,7 +154,7 @@ class WhenMock { } this.defaultReturnValue = returnValue => this.defaultImplementation(() => returnValue) this.defaultResolvedValue = returnValue => this.defaultReturnValue(Promise.resolve(returnValue)) - this.defaultRejectedValue = err => this.defaultResolvedValue(Promise.reject(err)) + this.defaultRejectedValue = err => this.defaultReturnValue(Promise.reject(err)) this.mockImplementation = this.defaultImplementation this.mockReturnValue = this.defaultReturnValue this.mockResolvedValue = this.defaultResolvedValue