Tag release-blocking issues

[Ekleog]

Hey! From my experience with it I'm thinking Marvin is really great already, and could probably already be released on some percentage of all incoming github PRs (just changing the regular-poke to something that sounds more like “people needing to /status needs_reviewer when reviewers don't answer is by design and not a bug”; and maybe making the introductory message more self-explanatory for beginners — verbosity is rarely a bad thing).

So I wonder: which of the current issues, in your mind, should block releasing Marvin to eg. 5% of all incoming PRs? (well… or at least publishing an RFC to that effect?)

If I can find some spare time I'd love to try to help you in getting Marvin used in production :)

[timokau]

Hi! I think the main blockers are those that I listed as caveats here. It's a good idea to collect all of them here though. Off the top of my head:

• Simplify rate limiting (Improving on the rate-limiting algorithm #102).
• More people need to get involved in development and administration. I do not want to have the sole responsibility for marvin once people actually start to depend on it. For that, we should try to lower the barrier of entry.
  • Currently every nix-community/infra administrator can deploy marvin and access the logs. I hear @Mic92 plans to work on continuous deployment. That would help. We should also clean up the logging and make the logs accessible without nix-community/infra administrator rights.
  • We need developer documentation (Document the testing process #113).
• We should move the reviewer list to the target repository (Store the reviewer team in the nixpkgs repo #93). That will decrease the maintenance burden and make testing easier.
• I would prefer to fix the timeout (PR not put back to 'needs_reviewer' #99), but with the current "workaround" I agree that it is not a blocker.
• I would also prefer to do some refactoring and improve automated tests (which would also lower the barrier for contribution).
• Someone needs to actually write the RFC and push for it ;)

The list is probably not complete, but it is a start. I am glad that you are interested in getting involved!

[Mic92]

I could setup loki to make logs accessible via grafana?

[timokau]

That would be great! I think the cleaning up step should come first though. We should at least double-check that nothing sensitive ends up in the log.