Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evict marvin from draft PR #40

Closed
blaggacao opened this issue Jul 4, 2020 · 3 comments
Closed

Evict marvin from draft PR #40

blaggacao opened this issue Jul 4, 2020 · 3 comments

Comments

@blaggacao
Copy link
Contributor

blaggacao commented Jul 4, 2020

marvin should evict draft PRs entirely.

  • Arguably, marvin's state machine is meant to kick in and push on the "last mile".
  • Draft PRs are a great way to signal "don't bother looking at this yet".

Example of awaiting_changes - in the context of marvin's state diagram - signalling a review process while being draft / [ WIP ]: NixOS/nixpkgs#58230


Idea (once marvin graduates into opt-out):

  • draft (thus evict) all new PRs upon creation
  • kick in marvin's state machine upon an activation intent by the author
    • /status needs_review or a semantic analogon, like /marvin go (which has going viral potential)
@timokau
Copy link
Owner

timokau commented Jul 4, 2020

Does this go further than #22? awaiting_changes seems appropriate for draft PRs. Note that awaiting_changes essentially takes a PR out of the triage loop.

I think most newly created PRs are "ready for review", publishing a WIP PR does happen but its not the norm.

@blaggacao
Copy link
Contributor Author

blaggacao commented Jul 4, 2020

Thanks for ref to #22!

This goes further.

Isolating and interpreting (in my understanding) the information bits:

  • Draft => "don't even bother looking at this, I'm in stealth mode"
  • awaiting_changes => "I'm in a state in marvin's state diagram which can have meanigful predecessores for the 'last mile' workflow"

So while Draft and awaiting_changes could have semantic overlap, the present issue argues they should not.

Avoiding the semantic overlap, essentially we can interpete awaiting_changes as follows:

  • awaiting_changes => "I'm in a state in marvin's state diagram and definitely bother looking at this and check why we are not progressing on the last mile" (either by the author or a helping hand)

Now, it doesn't (yet) happen very often, but by automatically setting new PRs to draft, we essentially introduce a new triage state which requires conscientious action by the author to push it out. This might be a good general state flow, because it gives the author time for the "battle" with the ofborg without appearing in reviewers search filters, yet, akin to the strict "I'm in stealth mode" interpretation.

Besides all that, by "essentially" and implicitly integrating Draft in marvin's state diagram, we get a powerful github visual "for free".

This was referenced Jul 4, 2020
@blaggacao
Copy link
Contributor Author

Superseded by #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants