-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evict marvin from draft PR #40
Comments
Does this go further than #22? I think most newly created PRs are "ready for review", publishing a WIP PR does happen but its not the norm. |
Thanks for ref to #22! This goes further. Isolating and interpreting (in my understanding) the information bits:
So while Draft and Avoiding the semantic overlap, essentially we can interpete
Now, it doesn't (yet) happen very often, but by automatically setting new PRs to draft, we essentially introduce a new triage state which requires conscientious action by the author to push it out. This might be a good general state flow, because it gives the author time for the "battle" with the ofborg without appearing in reviewers search filters, yet, akin to the strict "I'm in stealth mode" interpretation. Besides all that, by "essentially" and implicitly integrating Draft in marvin's state diagram, we get a powerful github visual "for free". |
Superseded by #49 |
marvin
should evict draft PRs entirely.Example of
awaiting_changes
- in the context ofmarvin
's state diagram - signalling a review process while being draft / [ WIP ]: NixOS/nixpkgs#58230Idea (once marvin graduates into opt-out):
/status needs_review
or a semantic analogon, like/marvin go
(which has going viral potential)The text was updated successfully, but these errors were encountered: