Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE build support for awskms #1

Open
ghost opened this issue Aug 17, 2022 · 1 comment
Open

CMAKE build support for awskms #1

ghost opened this issue Aug 17, 2022 · 1 comment
Assignees

Comments

@ghost
Copy link

ghost commented Aug 17, 2022

Help us help you

Hi team,
I've been building a C++ wrapper library that uses Tink in an opinionated way - specifically, Envelope AEAD backed by AWS KMS.
I need to target a deployment for Alpine containers, so using CMAKE is a better choice for my case (as far as I could tell Bazel is not available for Alpine and I'd rather not compile that from scratch as well).
All is fine (ish) to compile a library that wraps Tink - until the cc/integration folder comes into play, as it doesn't have CMakeLists.txt configured.

Is your feature request related to a problem?

There is no CMakeLists.txt definitions for the cc/integration folder, nor an easily importable symbol from the top-level CMakeLists.txt file

What sort of feature would you like to see?

A CMAKE symbol I can import in my CMakeLists.txt similar to the existing tink::static that is provided today.

Have you considered any alternative solutions?

I tried to patch the in-tree copy before compilation by adding a cc/integration/awskms/CMakeLists.txt but didn't quite figure out how to do it right.
The only way I got this working is by copying the relevant files as if they were in my build dir and change their namespaces, which is not great.

Would you like to add additional context?

I've done this with Tink 1.6.1, not tried yet with 1.7.0 but taking a look in the current master @ 27b061bb9ed1af1a6f538410bff443290e427e66 this looks like still an issue.

@morambro morambro self-assigned this Aug 17, 2022
@morambro
Copy link
Contributor

morambro commented Sep 2, 2022

Hi @foomeden, I am looking into this (though not at full time); I will post an update as soon as I have this figured out and a tentative timeline.

@morambro morambro transferred this issue from tink-crypto/tink Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants