Skip to content

Change the way ProphetModel works with regressors #329

Closed
1 task
julia-shenshina opened this issue Nov 29, 2021 · 1 comment · Fixed by #383
Closed
1 task

Change the way ProphetModel works with regressors #329

julia-shenshina opened this issue Nov 29, 2021 · 1 comment · Fixed by #383
Assignees
Labels
enhancement New feature or request

Comments

@julia-shenshina
Copy link
Contributor

🚀 Feature Request

Change models behavior in work with regressors

Motivation

New way of work with regressors.

Proposal

  • Change _ProphetModel.fit:
    • add arg regressors: Optional[List[str]] = None: all the given columns should be added to model as regressors
    • change this loop:
      • logic of cap and floor should be deleted
      • we understand that column is regressor not with prefix regressor but with x in regressors
  • Change _ProphetModel.predict:
  • Change ProphetModel.fit:
    • now it should get list of regressors names from ts and pass it to self.models.fit

Test cases

No response

Alternatives

No response

Additional context

No response

Checklist

  • I discussed this issue with ETNA Team
@julia-shenshina julia-shenshina added the enhancement New feature or request label Nov 29, 2021
@julia-shenshina
Copy link
Contributor Author

is blocked by #327 #326 #328

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants