Skip to content

Create MADTransform #426

Closed
1 task done
alex-hse-repository opened this issue Dec 29, 2021 · 0 comments · Fixed by #441
Closed
1 task done

Create MADTransform #426

alex-hse-repository opened this issue Dec 29, 2021 · 0 comments · Fixed by #441
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@alex-hse-repository
Copy link
Collaborator

alex-hse-repository commented Dec 29, 2021

🚀 Feature Request

Create MADTransform, which calculates rolling MAD (mean absolute deviation)

Motivation

New transform in statistics transforms zoo

Proposal

  1. Create class MADTransform(WindowStatisticsTransform) with the same constructor as base class
  2. Implement _aggregate_window, which calculates MAD

Test cases

  1. Update test_interface_simple
  2. Add the separate test to check the correctness of fit_transform method.
  3. Add test to check that it correctly work with NaNs(transform should be able to calculate statistic even with NaNs in the window)

Alternatives

No response

Additional context

No response

Checklist

  • I discussed this issue with ETNA Team
@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Dec 29, 2021
@julia-shenshina julia-shenshina self-assigned this Jan 10, 2022
@julia-shenshina julia-shenshina mentioned this issue Jan 10, 2022
9 tasks
@martins0n martins0n added this to the etna 1.6.0 milestone Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants