You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The contract: "list of regressors is a subset of list of the columns" should be checked after modifying the dataset in transform loop. The extra regressors should be deleted in _update_regressors method.
Motivation
In #328 we added the regressors updating logic to TSDataset. However after applying any feature selection we get the list of regressors inconsistent with the list of columns in dataset.
Proposal
Intersect the list of regressors with the list of columns in the end of _update_regressors method
Remove "xfail" mark from this test and make sure that it passes
Test cases
Check that the list of regressors is consistent with the list of columns after applying FilterFeaturesTransform
🚀 Feature Request
The contract: "list of regressors is a subset of list of the columns" should be checked after modifying the dataset in transform loop. The extra regressors should be deleted in
_update_regressors
method.Motivation
In #328 we added the regressors updating logic to TSDataset. However after applying any feature selection we get the list of regressors inconsistent with the list of columns in dataset.
Proposal
_update_regressors
methodTest cases
Check that the list of regressors is consistent with the list of columns after applying
FilterFeaturesTransform
Alternatives
No response
Additional context
Is blocked by #443
Checklist
The text was updated successfully, but these errors were encountered: