Skip to content

Create MultisegmentModel and inherit all Multisegment models from it #509

Closed
1 task done
iKintosh opened this issue Feb 7, 2022 · 0 comments · Fixed by #551
Closed
1 task done

Create MultisegmentModel and inherit all Multisegment models from it #509

iKintosh opened this issue Feb 7, 2022 · 0 comments · Fixed by #551
Assignees
@alex-hse-repository
Labels
enhancement New feature or request
Milestone
Architecture Impr...

Comments

@iKintosh
Copy link
Contributor

iKintosh commented Feb 7, 2022 •
edited by alex-hse-repository
Loading

🚀 Feature Request

CatboostMultisegmentModel and SklearnMultisegmentModel are now inherited from MultisegmentModel

Motivation

It should make architecture of multisegment models clearer

Proposal

Create MultisegmentModel
It should

  • implement method fit, it shout pass the list of regressors from dataset to fit method of base_model
  • implement method forecast

Classes CatboostMultisegmentModel and SklearnMultisegmentModel now contains only _init_ method. All the other logic should be moved to MultisegmentModel or its adapters.

Test cases

No response

Alternatives

No response

Additional context

No response

Checklist

  • I discussed this issue with ETNA Team
@iKintosh iKintosh added the enhancement New feature or request label Feb 7, 2022
@iKintosh iKintosh added this to the Architecture Improvements milestone Feb 7, 2022
@alex-hse-repository alex-hse-repository self-assigned this Feb 21, 2022
@alex-hse-repository alex-hse-repository mentioned this issue Feb 21, 2022
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alex-hse-repository alex-hse-repository

Labels
enhancement New feature or request
Projects
etna board
Status: Done
Milestone
Architecture Improvements
Development

Successfully merging a pull request may close this issue.

Create MultisegmentModel tinkoff-ai/etna
2 participants
@iKintosh @alex-hse-repository