You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make method more convenient for parameters selection
Proposal
Create method prophet_to_etna(holidays: pd.Dataframe) -> pd.Dataframe
Convert the format of holidays dataframe from Prophet see to the format of plot_holidays
Create method etna_to_prophet(holidays: pd.Dataframe) -> pd.Dataframe
Do it vice versa
Test cases
No response
Alternatives
No response
Additional context
No response
Checklist
I discussed this issue with ETNA Team
The text was updated successfully, but these errors were encountered:
Why not just make this format default to the library?
We have this exact format for ProphetModel already. Why should we support two different holiday formats?
Actually prophet_to_etna(holidays: pd.Dataframe) -> pd.Dataframe is not possible, since we have to know exactly start and end of TSDataset with data we want to apply these holidays to. Additionally we have to know frequency of TSDataset to build correct holiday_df.
🚀 Feature Request
Add dataframe format converter to
plot_holidays
Motivation
Make method more convenient for parameters selection
Proposal
prophet_to_etna(holidays: pd.Dataframe) -> pd.Dataframe
Convert the format of
holidays
dataframe from Prophet see to the format ofplot_holidays
etna_to_prophet(holidays: pd.Dataframe) -> pd.Dataframe
Do it vice versa
Test cases
No response
Alternatives
No response
Additional context
No response
Checklist
The text was updated successfully, but these errors were encountered: