Skip to content

Enhance HolidaysTransform #763

Closed
1 task
alex-hse-repository opened this issue Jun 21, 2022 · 0 comments · Fixed by #1340
Closed
1 task

Enhance HolidaysTransform #763

alex-hse-repository opened this issue Jun 21, 2022 · 0 comments · Fixed by #1340
Assignees
Labels
enhancement New feature or request priority/medium Medium priority task

Comments

@alex-hse-repository
Copy link
Collaborator

alex-hse-repository commented Jun 21, 2022

🚀 Feature Request

HolidaysTransform should make it possible to distinct between the holidays

Motivation

Make work with country holidays more flexible

Proposal

Add parameter mode which has two possible values:

  • binary: we have a binary column which represents the presense of the holiday.
  • category: we have a categorical column which represents which holiday do we have at each day. A special value is used for days without holiday.

Test cases

  1. Fix tests to check that both modes are working correctly.
  2. Check that inference tests at tests/test_transforms/test_inference are working correctly

Alternatives

No response

Additional context

No response

Checklist

  • I discussed this issue with ETNA Team
@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Jun 21, 2022
@alex-hse-repository alex-hse-repository added this to the New Features milestone Aug 17, 2022
@Mr-Geekman Mr-Geekman added the priority/medium Medium priority task label Jun 7, 2023
@Mr-Geekman Mr-Geekman removed this from the New Features milestone Jul 20, 2023
@malodetz malodetz self-assigned this Jul 26, 2023
@malodetz malodetz mentioned this issue Jul 31, 2023
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request priority/medium Medium priority task
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants