You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello! I am currently using tinygo with msgp. However, tinygo version 0.31.0 started passing the flag purego which is causing the performance to take a hit, despite being okay with using the unsafe library.
I'd like to propose adding another flag into the msgp/unsafe.go and msgp/purego.go so that even if the purego flag is true, we can bypass and still use the unsafe library by setting another flag. Keeping the purego flag so that current uses aren't impacted.
This issue (purego disabling unsafe instead of just assembly and cgo) was raised by one of the TinyGo developers at the time golang/go#23172 (comment) .
Hello! I am currently using tinygo with msgp. However, tinygo version 0.31.0 started passing the flag
purego
which is causing the performance to take a hit, despite being okay with using the unsafe library.I'd like to propose adding another flag into the
msgp/unsafe.go
andmsgp/purego.go
so that even if the purego flag is true, we can bypass and still use the unsafe library by setting another flag. Keeping the purego flag so that current uses aren't impacted.ie) Change
msgp/purego.go
from:to:
With a similar change in
msgp/unsafe.go
Thanks!
The text was updated successfully, but these errors were encountered: