Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.0 requires "resolver" due to Cargo bug #127

Closed
adamreichold opened this issue Sep 17, 2022 · 6 comments
Closed

0.8.0 requires "resolver" due to Cargo bug #127

adamreichold opened this issue Sep 17, 2022 · 6 comments

Comments

@adamreichold
Copy link

The Cargo.toml published with 0.8.0 contains the "resolver" key which is not present in the original Cargo.toml suggesting that the package was published using a Cargo version affected by rust-lang/cargo#10954

Could you publish a semver-compatible release that does not contain the "resolver" key? This would allow the rust-numpy crate to update its dependency on ahash without changing MSRV, c.f. https://github.com/PyO3/rust-numpy/actions/runs/3073552488/jobs/4965760601

@adamreichold
Copy link
Author

Friendly ping. Just reuploading with a bumped version and using a current Cargo would really help. Thanks!

@tkaitchuck
Copy link
Owner

I am working on 0.8.1 which will also have some other improvements.

@tkaitchuck
Copy link
Owner

I just released 0.8.1, but it has the same problem. Is this caused because I released using nightly?

@adamreichold
Copy link
Author

I just released 0.8.1, but it has the same problem. Is this caused because I released using nightly?

It should not be the case when the current nightly is used, only if you have pinned the version to one still affected by the above mentioned bug.

@tkaitchuck
Copy link
Owner

This appears to have been fixed with the 0.8.2 release. I will release using stable from now on as a precaution. Closing for now.

@adamreichold
Copy link
Author

adamreichold commented Nov 11, 2022

Thanks, the resolve issue is now fixed indeed.

Sadly, we cannot bump to 0.8.x as the atomic-polyfill feature shadows a dependency which the Rust 1.48 toolchain that is shipped by Debian does not yet support, so we'll have to stick to 0.7.x for now after all, c.f. https://github.com/PyO3/rust-numpy/actions/runs/3442951690/jobs/5744015218.

If I could make a wish, adding the rust-version key to this crate's Cargo.toml would be nice. (I would make a PR but I did not find MSRV information.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants