Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Games dispeared after adding a tag to 1. #99

Closed
markmorris opened this issue Oct 10, 2018 · 11 comments
Closed

Games dispeared after adding a tag to 1. #99

markmorris opened this issue Oct 10, 2018 · 11 comments

Comments

@markmorris
Copy link

After adding a tag to a game (Outlast) all games disappeared, nothing i can do to change it, i toggle all settings including merge games, still blank.

No matter what its blank, this is 10 mins after app is loaded to test if it was slow loading times.
screenshot from 2018-10-10 10-31-58

Loving the app, lets get it fixed up!

@tkashkin
Copy link
Owner

Try to switch some tags in filters popover (tag icon on headerbar).

It should display all games without any filtering if all or no tags are selected.

It should display games that have at least one of selected tags otherwise.

You may have encountered this bug. It is already fixed in dev branch.

@markmorris
Copy link
Author

Tried everything. Switching back between views, games etc etc does nothing.

Thank you for your fast replies.

screenshot from 2018-10-10 11-00-05

@tkashkin
Copy link
Owner

Ok, then it should be something new. I'll take a look later today (or in a few days depending on free time).

Distro, app version, reproduce steps and logs will be helpful.

@markmorris
Copy link
Author

markmorris commented Oct 10, 2018

Currently using ElementaryOS, cant find app version anywhere but i only installed today, so assuming its the latest.

EDIT:
Could this error have anything to do with me having 280+ games?

EDIT:
The issue is Show non-native games, it hides ALL games for me if i turn it off, i have many native linux games including DOTA 2, which it thinks is a windows game.

@markmorris
Copy link
Author

Example of Show non-native games bug.

screenshot from 2018-10-10 12-10-02

screenshot from 2018-10-10 12-10-13

@tkashkin
Copy link
Owner

tkashkin commented Oct 10, 2018

It's a weird issue, I'm not sure yet why that happens.

I don't get it with my locally built, not installed version, but I do get it with packages and AppImages built on AppVeyor or launchpad (btw PPA for Ubuntu-based distros is now available).
More weird is that I get it even with a deb package built on my system.

Bug should be somewhere in native/non-native games detection.
If you enable "Use compat layers" option, it should be mostly ok, except all games being "non-native".


Try to build it on your system and see if you'll have the same result as me.
Here are exact commands I test with:

meson build --prefix=/usr -Ddistro=debian --buildtype=debug
cd build
ninja && src/com.github.tkashkin.gamehub --debug

Could this error have anything to do with me having 280+ games?

Good assumption, but no, it's definitely not a problem. 🙂
image

@tkashkin tkashkin mentioned this issue Oct 21, 2018
@tkashkin
Copy link
Owner

I have found a reason for this weird behavior. It was due to compiler optimizations.
There was a discussion of this issue in #103.

Packages built on AppVeyor should work properly. I'm still trying to pass required options to launchpad to disable optimizations for PPA builds.

@tkashkin
Copy link
Owner

@markmorris, @Hedronmx launchpad builds are now built without optimizations.

@Hedronmx
Copy link

Sweet, anyway to check changelogs?

@tkashkin
Copy link
Owner

Sweet, anyway to check changelogs?

I'm too lazy to document all changes, so best thing you can do is to check commits list.

@Hedronmx
Copy link

I see, thank you! Please let me know when I can donate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants