-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC candidates from Jedi.el are not merged with others #57
Comments
It turned out that it is nothing to do with async (as @MarSik suggested #40 (comment)). Instead, this happens because that AC can merge sources with the same "prefix" attribute. You can check that candidates from Jedi are merged with others if you remove this restriction by this patch on diff --git a/auto-complete.el b/auto-complete.el
index f04f3cb..37167b6 100644
--- a/auto-complete.el
+++ b/auto-complete.el
@@ -977,7 +977,7 @@ You can not use it in source definition like (prefix . `NAME')."
(if point
(setq prefix-def prefix))))
- if (equal prefix prefix-def) do (push source sources)
+ do (push source sources)
finally return
(and point (list prefix-def point (nreverse sources))))) Here Hopefully this restriction is removed in AC2. Pinging @MarSik, @asmeurer and @m2ym. |
Do you want me to test it or what? I don't know enough about the architecture of auto-complete to comment on the patch. If this can't be done until AC2, would the workaround be to add the prefix to the emacs-jedi source (either in emacs-jedi or have users to it in their .emacs)? |
@asmeurer It's just to let you know status of the issue. I don't think there is a workaround except applying the above patch (I don't know if it is usable, though. Maybe you can put some conditions there to activate the patch only in Python buffer etc., to make it slightly more usable). Other thing we can do is to implement equivalent of sources like words-in-buffer and dictionary at Python side, so that you can mix these candidates without changing jedi.el. Or adding more to Jedi's "dictionary" (I think there is only builtins; no conventional variable like |
I think the auto-complete Python dictionary is just |
See the original report in #40.
The text was updated successfully, but these errors were encountered: