Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client spec: osx and macos #7076

Closed
niklasmohrin opened this issue Oct 17, 2021 · 4 comments · Fixed by #7514
Closed

Client spec: osx and macos #7076

niklasmohrin opened this issue Oct 17, 2021 · 4 comments · Fixed by #7514

Comments

@niklasmohrin
Copy link

Hi everyone!

Over at tealdeer we wanted to allow users to specify macos as a platform for filtering pages (see tealdeer-rs/tealdeer#108 (comment) and tealdeer-rs/tealdeer#215).

It would of course be great if we could get confirmation from you guys that you won't add a "macos" platform any time soon - or a hard "no" if you are planning to do so. Maybe this alias could even manifest itself in the client spec as a recommendation or option. After all, the operating system is not called "osx" anymore.

Is this alias something the client spec authors would approve or are we shooting ourselves in the foot here? I would love to hear your thoughts on this!

Slightly related: #5013

@CleanMachine1
Copy link
Member

CleanMachine1 commented Oct 17, 2021

As mentioned in one of the issues, changing will break a lot of clients or functionality. Some clients are actively used by people however no longer maintained.

Until we make the entire switch which doesn't look likely yet, I feel tealdeer using an "alias" of some kind in its code would be the best solution.

don't take my word as any final say! I am just 1 of the many maintainers with different opinions.

@pixelcmtd
Copy link
Member

The best solution for all clients would be to have a check like

if "pages/macos" exists:
    alias "osx" to "macos"
else:
    alias "macos" to "osx"

as getting that into 90% of the clients allows for a very smooth transition.

@dbrgn
Copy link
Contributor

dbrgn commented Oct 18, 2021

Hm, I think it would be easier to keep the osx name for the pages directory. It doesn't hurt, as it's not part of the user-facing API.

However, the macos alias could be made into a recommendation in the client spec.

@sbrl
Copy link
Member

sbrl commented Dec 5, 2021

Hmmmmm, this is a great point. Ideally, we should move osx to macos, but as you say it would unfortunately break clients. Aside from assessing the various clients to see which ones would actually break, an alias would be a great thing to add in the meantime to the spec. Would you like to open a pull request for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants