Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and fix build error in wasm-test-runner #564

Closed
th4s opened this issue Aug 13, 2024 · 4 comments · Fixed by #567
Closed

Investigate and fix build error in wasm-test-runner #564

th4s opened this issue Aug 13, 2024 · 4 comments · Fixed by #567

Comments

@th4s
Copy link
Member

th4s commented Aug 13, 2024

Currently our wasm-test-runner fails with

error[E0599]: no method named `clone` found for struct `JsStatic` in the current scope
  --> /home/th4s/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wasm-bindgen-rayon-1.2.1/src/lib.rs:81:13
   |
81 |         URL.clone()
   |             ^^^^^ method not found in `JsStatic<JsString>`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `wasm-bindgen-rayon` (lib) due to 1 previous error

To reproduce go into wasm-test-runner and do a cargo clean && cargo update then execute ./run.sh.

@th4s
Copy link
Member Author

th4s commented Aug 13, 2024

Probably related to a recent update of js-sys but I could not get it working spending a few minutes on downgrading js-sys. Probably more crates need to be down-graded.

@th4s
Copy link
Member Author

th4s commented Aug 13, 2024

Eventually related: rustwasm/wasm-bindgen#4057

@th4s
Copy link
Member Author

th4s commented Aug 15, 2024

This can be more easily reproduced by cd into crates/wasm and then doing a cargo check -F no-bundler. It seems that this feature is causing it.

@th4s th4s linked a pull request Aug 15, 2024 that will close this issue
@th4s
Copy link
Member Author

th4s commented Aug 16, 2024

Closed by #567

@th4s th4s closed this as completed Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant