diff --git a/cpp/src/arrow/filesystem/azurefs.cc b/cpp/src/arrow/filesystem/azurefs.cc index ac563b134586e..6685f6bc351d0 100644 --- a/cpp/src/arrow/filesystem/azurefs.cc +++ b/cpp/src/arrow/filesystem/azurefs.cc @@ -2898,6 +2898,7 @@ class AzureFileSystem::Impl { } auto src_url = GetBlobClient(src.container, src.path).GetUrl() + sas_token; auto dest_blob_client = GetBlobClient(dest.container, dest.path); + auto src_url = GetBlobClient(src.container, src.path).GetUrl(); if (!dest.path.empty()) { auto dest_parent = dest.parent(); if (!dest_parent.path.empty()) { diff --git a/cpp/src/arrow/filesystem/azurefs_test.cc b/cpp/src/arrow/filesystem/azurefs_test.cc index ed09bfc2fadd7..24031e313f798 100644 --- a/cpp/src/arrow/filesystem/azurefs_test.cc +++ b/cpp/src/arrow/filesystem/azurefs_test.cc @@ -392,7 +392,7 @@ class TestGeneric : public ::testing::Test, public GenericFileSystemTest { bool allow_move_dir() const override { return false; } bool allow_move_file() const override { return true; } bool allow_append_to_file() const override { return true; } - bool have_directory_mtimes() const override { return true; } + bool have_directory_mtimes() const override { return false; } bool have_flaky_directory_tree_deletion() const override { return false; } bool have_file_metadata() const override { return true; } // calloc() used in libxml2's xmlNewGlobalState() is detected as a @@ -429,8 +429,6 @@ class TestAzuriteGeneric : public TestGeneric { protected: // Azurite doesn't support moving files over containers. bool allow_move_file() const override { return false; } - // Azurite doesn't support directory mtime. - bool have_directory_mtimes() const override { return false; } // DeleteDir() doesn't work with Azurite on macOS bool have_flaky_directory_tree_deletion() const override { return env_->HasSubmitBatchBug(); @@ -451,8 +449,6 @@ class TestAzureFlatNSGeneric : public TestGeneric { protected: // Flat namespace account doesn't support moving files over containers. bool allow_move_file() const override { return false; } - // Flat namespace account doesn't support directory mtime. - bool have_directory_mtimes() const override { return false; } }; class TestAzureHierarchicalNSGeneric : public TestGeneric { diff --git a/cpp/src/arrow/filesystem/test_util.cc b/cpp/src/arrow/filesystem/test_util.cc index 8eb00b8ae44f3..19226ce01ae2f 100644 --- a/cpp/src/arrow/filesystem/test_util.cc +++ b/cpp/src/arrow/filesystem/test_util.cc @@ -752,7 +752,7 @@ void GenericFileSystemTest::TestGetFileInfoSelector(FileSystem* fs) { } void GenericFileSystemTest::TestGetFileInfoGenerator(FileSystem* fs) { -#if defined(ADDRESS_SANITIZER) || defined(ARROW_VALGRIND) +#ifdef ADDRESS_SANITIZER if (have_false_positive_memory_leak_with_generator()) { GTEST_SKIP() << "Filesystem have false positive memory leak with generator"; }