-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a <<select>>
macro
#241
Comments
It would be great if it also fires an event when the timer runs out, passing the ID of the QTE that generated it |
Also, a possibility to pause the timer would be nice, reasoning an author could make an "extra time" button or some "easy" game mode! |
It'd be nice to have an easy way to disable the timer alltogether (maybe if the time value is I can see qte timing being offered as a setting, going from fast to entirely disabled. <<qte `(3* settings.qteSpeed)+'s'`>>...<</qte>> |
Made some edits to the issue. |
The ID is optional, so that's a wash. The event target will be the wrapper element though, which is better anyway. |
Yeah, that makes sense |
I'm thinking about using a button to unlock the content and timer rather than by scrolling into view. This would almost certainly be better in situations where there's considerable text before the QTE that the player may want or need to read—for the QTE to make sense. |
Updates to the OP. The macro will be more generally useful. Might change the name since Sleepy has a |
Maybe |
Select doesn't seem like the right word to me, but I can't think of anything better, either. Not helpful, I know, but I'll think about it. |
Name suggestions, some variant on "time limit"
|
Too close to I need to formally deprecate those two, so I can reuse the names someday.
The current intent is a generic selection macro, so time-/duration-based names are a bust. It still has a time option, so it can be a QTE, but that's not the sole thrust anymore. |
Please do. 🙏🏻 I hit the thesaurus already, but that was a bust. Then again, I was probably thinking too narrowly. |
Looking again, then, maybe right name is Contents could then be links, Not to feature-creep, but if the same worked with |
I agree with Hituro in the sense that this feels like two macros in a trenchcoat:
It is true that limiting the qte target to being a link feels arbitrary, and it'd be convenient to be able to attach a click listener to any element. But in this situation, a macro which could listen for any event type would solve more issues and have broader uses. <<listen>>
The answer is:
<<numberbox '$var' 0>>
<<when 'change'>>
<<if $var === 15>>
<<goto 'GoodJob'>>
<</if>>
<</listen>> |
That's not happening for exactly the same reason I gave to Greyelf. It's too close to the name of an existing macro. Simply adding or removing an "s" is not sufficient. I should have hard deprecated those two miserable things ages ago. Missed opportunity that. /sigh
The active contents, as noted above, are
I'll be sticking with the
That's not really feasible in v2 for a few reasons:
My personal preference is targeted applications built into macros that need it rather than attempting to have some generic catch all that's not much better than using a little JavaScript. E.g., making |
Maybe I should just suck it up and add an event wrapper macro as a stopgap in v2 until I can fix the core macro set in v3. I just don't want to get into a situation where people are Feh. 🤦🏻 Going to drive myself crazy with this. |
Another potential issue with the name |
The name's not going to be |
What it says on the tin.
Arguments
Optional
text
description
: (string) The text to display to the player that must be clicked on to reveal the selection content. If not specified, the selection content is automatically displayed.id
identifier
: (string) The unique CSS/DOM ID assigned to the selection wrapper element.class
classes
: (string) The space separated list of CSS/DOM classes assigned to the selection wrapper element.time
: (time unit) The time until the selections time out and are disabled, in CSS compatible time units—e.g.,10s
. If the time is set to zero—e.g.,0s
—then the timer is disabled and no timeout will occur.meter
name
: (bar
|radial
) The type of meter used to show the remaining time if thetime
option is specified. Defaults tobar
.Events
:select
event will be fired from the selection wrapper.time
option is specified and the player fails to select a link in time, a:selecttimeout
event will be fired from the selection wrapper.Notes
time
option is specified, the timer will start only once the selection contents are displayed and within view. Strolling the selection out of view, once started, does not affect the running timer.Ideas
<<select>>
. Possibilities:<<choose>>
,<<event>>
, …?The text was updated successfully, but these errors were encountered: