Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Career-long Charts #1

Open
airstrike opened this issue Mar 11, 2016 · 2 comments
Open

Career-long Charts #1

airstrike opened this issue Mar 11, 2016 · 2 comments

Comments

@airstrike
Copy link

Hi,

First of all, congratulation on this fantastic work. I honestly believe the pros at NBA are going to check these charts out quite a bit. You can get a lot of information out of them, and very intuitively so.

Have you considered allowing users to not filter by season, therefore getting stats for a player's entire career? I'm sure many would like to see that. I think you can take that a step further and do charts that compare a player's performance against his own, across his career, highlighting good and bad years. It should allow us to see when a player peaked and compare his performance across different teams.

Anyway, keep up the good work!

@toddwschneider
Copy link
Owner

Thanks. I agree career-long charts would be a good addition. In the meantime you can do stuff like this to grab all shots for a player: https://github.com/toddwschneider/ballr/blob/master/lebron.R#L4-L7

I might look into adding multi-season charts as an option in the main app, though I worry that the multiple NBA API requests will take too long for a single web request. One possibility is to build a custom backend that caches NBA data and exposes an endpoint to get career-long charts in a single request, but that'll be a bunch more work too...

@toddwschneider
Copy link
Owner

@airstrike no real update here, but I made a new project to store all shots in a database, check it out here: https://github.com/toddwschneider/nba-shots-db

Still some work to do to connect this app to that database to provide career-long charts, but it's a step in the right direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants