From 0bd94826f04b7ead7dc6a0ad2ac749374cd2dfd3 Mon Sep 17 00:00:00 2001 From: Gabriel Hansson Date: Fri, 22 Mar 2024 17:31:11 +0100 Subject: [PATCH] Minor clippy lint fixes. (#1006) --- prost-build/src/lib.rs | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/prost-build/src/lib.rs b/prost-build/src/lib.rs index d972a85df..2811e5854 100644 --- a/prost-build/src/lib.rs +++ b/prost-build/src/lib.rs @@ -205,36 +205,26 @@ pub trait ServiceGenerator { /// The map collection type to output for Protobuf `map` fields. #[non_exhaustive] -#[derive(Clone, Copy, Debug, PartialEq)] +#[derive(Default, Clone, Copy, Debug, PartialEq)] enum MapType { /// The [`std::collections::HashMap`] type. + #[default] HashMap, /// The [`std::collections::BTreeMap`] type. BTreeMap, } -impl Default for MapType { - fn default() -> MapType { - MapType::HashMap - } -} - /// The bytes collection type to output for Protobuf `bytes` fields. #[non_exhaustive] -#[derive(Clone, Copy, Debug, PartialEq)] +#[derive(Default, Clone, Copy, Debug, PartialEq)] enum BytesType { /// The [`alloc::collections::Vec::`] type. + #[default] Vec, /// The [`bytes::Bytes`] type. Bytes, } -impl Default for BytesType { - fn default() -> BytesType { - BytesType::Vec - } -} - /// Configuration options for Protobuf code generation. /// /// This configuration builder can be used to set non-default code generation options. @@ -1559,7 +1549,6 @@ mod tests { use std::cell::RefCell; use std::fs::File; use std::io::Read; - use std::path::Path; use std::rc::Rc; use super::*; @@ -1726,7 +1715,7 @@ mod tests { // Prior to PR introducing this test, the generated include file would have the file // google.protobuf.rs which was an empty file. Now that file should only exist if it has content - if let Ok(mut f) = File::open(&previously_empty_proto_path) { + if let Ok(mut f) = File::open(previously_empty_proto_path) { // Since this file was generated, it should not be empty. let mut contents = String::new(); f.read_to_string(&mut contents).unwrap();