Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatype for 64-bit integers (long long)? #42

Open
golddranks opened this issue Dec 26, 2019 · 2 comments
Open

Datatype for 64-bit integers (long long)? #42

golddranks opened this issue Dec 26, 2019 · 2 comments

Comments

@golddranks
Copy link
Contributor

Hi, there is DataType::Integer. I was wondering if it's meant to signify 32-bit integers, (int in MySQL and integer in Postgres). Is there a plan for having a data type for 64-bit integers?

It would also be very helpful if there were a correspondence table between the data types of this library, standard SQL and commonly used DB's such as Postgres, MySQL and Sqlite.

@golddranks
Copy link
Contributor Author

Note: this is not because it would be impossible to get 64-bit integers from the database at the moment; get_i64 seems to work just fine. However, it's because when dealing with databases with unknown schemas, we want to be able to inspect the metadata to know the correct numeric ranges that might be stored in the DB.

@andygrove
Copy link
Contributor

Yes, good point. I was just roughing out the DataTypes enum to get some basic tests working. I really want to study both the ODBC and JDBC specifications and learn from how they both modeled the data types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants