net: reintroduce getter/setter for SO_LINGER to tokio::net::tcp::stream #3143
Conversation
tokio/src/net/tcp/stream.rs
Outdated
| /// # } | ||
| /// ``` | ||
| pub fn linger(&self) -> io::Result<Option<Duration>> { | ||
| let mio_socket = mio::net::TcpSocket::from(self); |
There was a problem hiding this comment.
It should be possible to access self.io.get_linger(), similar to how nodelay does it above.
There was a problem hiding this comment.
There are no linger options in either Mio's TcpStream which self.io refers to nor its inner which is std::net::tcp
There was a problem hiding this comment.
@seanmonstar I actually don't think that's right; the methods for getting and setting SO_LINGER are defined on mio's TcpSocket type, not on its TcpStream, and self.io is a TcpStream.
That does bring up a different question, though: is there any reason it's necessary to expose these methods on Tokio's TcpStream type, rather than on its TcpSocket type? tokio::net::TcpSocket wraps mio's TcpSocket...
There was a problem hiding this comment.
Oh, I'm sorry, I misread that as TcpStream::from instead of TcpSocket.
There was a problem hiding this comment.
@hawkw In our use case (pre tokio 0.3) we set the linger option from a stream object not TcpSocket.
I could also update this PR to also expose this on tokio::net::TcpSocket.
There was a problem hiding this comment.
I am a bit confused here. set_linger is on the mio socket and PollEvented holds the mio socket? PollEvented also derefs to the mio socket, so why does self.io.get_linger() not work?
There was a problem hiding this comment.
PolledEvented holds Mio TcpStream
There was a problem hiding this comment.
Ah yes, that is terribly confusing 😆
Darksonn
added
A-tokio
Motivation
The ability to set_linger option on a TcpStream was removed in v0.3 so that TcpStream could be similar to std. I wasn't able to find the reason for why this
set_lingerwas removed from std's TcpStream.This PR reintroduces this option.
Solution
Convert the stream using it's raw fd to get a mio TcpSocket and set the option.