Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing-futures: What's blocking the 0.3 release? #1180

Closed
d-e-s-o opened this issue Jan 9, 2021 · 4 comments
Closed

tracing-futures: What's blocking the 0.3 release? #1180

d-e-s-o opened this issue Jan 9, 2021 · 4 comments

Comments

@d-e-s-o
Copy link
Contributor

d-e-s-o commented Jan 9, 2021

Please see above. I see Cargo.toml already mentioning version 0.3, but can't seem to find it on crates.io. What's the hold up? Also, 971a46b tagged version 0.2.6, which is also not available on crates.io ...?

@hawkw
Copy link
Member

hawkw commented Jan 13, 2021

I see Cargo.toml already mentioning version 0.3, but can't seem to find it on crates.io. What's the hold up?

The current master branch is targeting tracing 0.2.x development --- tracing-futures on master has its version bumped to 0.3 because updating the tracing dependency to 0.2.x will be a breaking change, when 0.2 is released. The current state of the released versions is on the v0.1.x branch.

You can track progress on tracing 0.2 in issues #922 and #923. The honest answer to the question "what's the hold-up?" is that work on 0.2 has been progressing fairly slowly because I have other responsibilities as well, and have been prioritizing maintenance for the released v0.1.x ecosystem over working on the breaking changes.

Also, 971a46b tagged version 0.2.6, which is also not available on crates.io ...?

Hmm, that looks like a mistake --- as you can see from the commit message, that commit was supposed to update the tracing-subscriber crate's version to 0.2.6. It looks like the tracing-futures version in Cargo.toml was only changed due to a find-and-replace mistake. My bad! As you can see, the latest version in the changelog is 0.2.4.

Hopefully that helps answer your questions --- is there any specific unreleased change you're waiting for?

@d-e-s-o
Copy link
Contributor Author

d-e-s-o commented Jan 14, 2021

Interesting. Thanks for the explanation. The background of my question is that tracing-futures 0.2 pulls in pin-project ^0.4, which is now causing a duplication with other crates (e.g., hyper) that moved on to depending on 1.0. I'd like to get rid of this duplication where possible. The bump has happened already on the master branch of tracing-futures (cd911e0).

Is there any chance another 0.2 release cut be cut that includes this bump as well? That is, if I were to submit a pull request bumping the dependency, would it be accepted (and a new 0.2 release be cut eventually)?

@benesch
Copy link

benesch commented Jan 27, 2021

Is there any chance another 0.2 release cut be cut that includes this bump as well? That is, if I were to submit a pull request bumping the dependency, would it be accepted (and a new 0.2 release be cut eventually)?

We at @MaterializeInc would also really appreciate a release with this bump!

@d-e-s-o
Copy link
Contributor Author

d-e-s-o commented Feb 28, 2021

Seems to have been fixed with 0.2.5. Thanks!

@d-e-s-o d-e-s-o closed this as completed Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants