Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only seeing "in progress" when running within a matrix #33

Open
dakota-maker-by opened this issue Dec 2, 2020 · 13 comments
Open

Only seeing "in progress" when running within a matrix #33

dakota-maker-by opened this issue Dec 2, 2020 · 13 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@dakota-maker-by
Copy link

Hi there,

I am trying to run this action within a workflow that relies on matracies:

  deploy:
    runs-on: ubuntu-latest
    needs: build-deployment-envs
    strategy:
      matrix: ${{ fromJson(needs.build-deployment-envs.outputs.matrix) }}
    
   ...

      - name: Check for failure and set card layout
        if: failure()
        run: echo "CARD_LAYOUT=complete" >> $GITHUB_ENV

      - name: Publish Deployment Card
        uses: toko-bifrost/[email protected]
        if: always()
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          webhook-uri: ${{ webhook URL secret name }}
          environment: ${{ matrix.env }}
          show-on-start: false
          show-on-exit: true
          card-layout-exit: ${{ env.CARD_LAYOUT }}
          view-status-action-text: "View status (${{ matrix.mfeName }})"

but regardless of how the run is going, we are only seeing "In Progress". I made sure to not have job names in place, so I know the known issue #5 is not impacting this, but the next culprit seems to be running within a matrix. Not sure if there was any insight on this but I wanted to report it for visibility if nothing else.

@mombe090
Copy link

mombe090 commented Dec 2, 2020

Hey i have the same issue

@aldwyn-acn
Copy link
Contributor

Hey guys, I will look into this.

@aldwyn-acn aldwyn-acn added bug Something isn't working enhancement New feature or request labels Dec 3, 2020
@aldwyn-acn aldwyn-acn self-assigned this Dec 3, 2020
@dnepusb2
Copy link

dnepusb2 commented Dec 9, 2020

Have the same issue.

@mshirman
Copy link

Same here. The completion status is always IN-PROGRESS

@dmbarry86
Copy link

Same here. Any update on this since December?

@marcosmesser
Copy link

I am using a work around for this issue, might be useful for someone else.

  notification-job:
    runs-on: ubuntu-latest
    needs: [job-with-matrix]
    if:  "always() && !contains(github.event.head_commit.message, '[skip ci]')"

    steps:
      - name: Checkout branch code
        uses: actions/checkout@v2

      - uses: toko-bifrost/ms-teams-deploy-card@master
        if: always()
        with:
          card-layout-exit: complete
          show-on-start: false

      - name: Build matrix failed
        if: ${{ needs.job-with-matrix.result != 'success' }}
        run: exit 1

      - name: Build matrix succeeded
        if: ${{ needs.job-with-matrix.result == 'success' }}
        run: echo "Targets built and deployed"

The notification won't have the actual error, but it will at least have the right status for the whole workflow.

@dkbhadeshiya
Copy link

Same here. Any update on the status here? Thanks.

@dkbhadeshiya
Copy link

In my findings, the same behaviour happens even when we are not running it in matrix.

@patrickpaulin
Copy link

patrickpaulin commented Apr 26, 2021

Recently I opened a PR to solve this issue. Take a look

@michal-sa
Copy link

I was seeing this issue as well and just confirmed your PR did solve it @patrickpaulin, would be nice to get it merged if/when possible. Good job with the fix 👍

@patrickpaulin
Copy link

Tks, @michal-sa!

it looks like this repo was "abandoned". Feel free to use my fork, for while:

patrickpaulin/ms-teams-deploy-card@master

@floptical
Copy link

floptical commented Oct 20, 2021

Ditto on this issue with the notification always being "in-progress", even when not using -name for the teams step. Thanks for the fork @patrickpaulin

@hubert17
Copy link

@patrickpaulin Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests