Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to insert timestamp in note #156

Open
obilodeau opened this issue Aug 23, 2016 · 5 comments
Open

Allow to insert timestamp in note #156

obilodeau opened this issue Aug 23, 2016 · 5 comments

Comments

@obilodeau
Copy link
Member

obilodeau commented Aug 23, 2016

When using tomboy in laptop, we can insert time stamp in note (using plugin)
It would be great if allowed to insert timestamp while mobile.

thanks


Imported from Launchpad using lp2gh.

@obilodeau
Copy link
Member Author

(by chatmellow)
I tried to implement as well as I can the timestamp feature. That's my first contribution to an open source. Not such a great thing, but ... it's something /o/.

Greetings~

Cédric.

@obilodeau
Copy link
Member Author

(by j-4)
Hi,

Thanks for you contribution.
However, your patch is somehow weird as it contains tons of images and it seems that every line is a new line :-)
Best to contribute is to create a new tomdroid branch and link it to the bugreport.

just do a
bzr push lp:~[username]/tomdroid/[newBranchTitle]
to upload your changes to such a new branch!
As soon as you are finished, klick the "Propose for merging" link in the webview:
https://code.launchpad.net/~[username]/tomdroid/[newBranchTitle]

Looking forward to your merging proposal :-)

@obilodeau
Copy link
Member Author

(by chatmellow)
I was really not sure about my patch and you are confirming my doubt. Thank you very much for taking the time to help, I'll follow all these steps when I will be back home.
Greetings.

Cédric.

@obilodeau
Copy link
Member Author

(by chatmellow)
Hi there,

I really encountered troubles to do just that simple commit, but it's really interesting to discover.
I've just created my new branch and proposed it for merging, I trully hope it's working this time. I also did a working patch, in case of.

Greetings~

@obilodeau
Copy link
Member Author

(by j-4)
Hi!

Baraar is quite easy, there are just a few steps to do to commit something to a branch

  1. bzr branch lp:tomdroid
  2. Make your changes to the code
  3. bzr commit -m "Commit message what was changed and which bugs fixed etc"
  4. bzr push lp:~username/tomdroid/branchname
    (or lateron just bzr push is needed!)

Your changes look good already - however there are a couple of things missing.
To be really format compatible with Tomboy we need to save the timestamp in a xml tag called
Therefore we first need to be able to parse and format this tag accordingly.
Then we can also write it with you already perfect button!

You can play around a little bit if you want, otherwise I will just write it as soon as i have time!
Thanks for you contribution - very good so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant