Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicating Core Operators does not populate Enum #283

Open
sense-amr opened this issue Aug 13, 2023 · 10 comments
Open

Duplicating Core Operators does not populate Enum #283

sense-amr opened this issue Aug 13, 2023 · 10 comments
Assignees
Labels
bug An issue that should be fixed. operator This can be solved by added a new operator. ui Task is related to user interface

Comments

@sense-amr
Copy link
Contributor

sense-amr commented Aug 13, 2023

When duplicating a Core operator .. for use in your own namespace library ..
Enums from that operator do not populate in your duplicate version ..

image1

original with enum

image

Duplicated version with out enum

@pixtur pixtur self-assigned this Aug 23, 2023
@pixtur pixtur added bug An issue that should be fixed. ui Task is related to user interface operator This can be solved by added a new operator. labels Aug 23, 2023
@teadrinker
Copy link
Contributor

teadrinker commented Aug 29, 2023

If the user case/need is to be able edit a built-in operator (without messing up everything else)
I think a faster workflow would be: Rightclick->"Symbol definition->Replace with local duplicate".
So that the operator instance settings and connectons are preserved, but use the created local duplicate.

Ideally the user would also be able to swap symbols (this would require some good error handling (or just strictly work on identical specs))

So in a sense "Replace with local duplicate" == "Duplicate as new type..." + "Swap Symbol"

@sense-amr
Copy link
Contributor Author

the quickest method is that which was already working fine .. up untill the last update..
and that is that you rename it in the parameters window .. up untill the last update .. this was working fine..
i have logged a bug with this last commit and pixtur is aware of it

@sense-amr
Copy link
Contributor Author

oh and it looks like he's managed to fix it ..
image

@sense-amr
Copy link
Contributor Author

the quickest method is that which was already working fine .. up untill the last update.. and that is that you rename it in the parameters window .. up untill the last update .. this was working fine.. i have logged a bug with this last commit and pixtur is aware of it

also your mention of something that has nothing to do with this issue .. this issue is related to ENUMS not populating when using a duplicated symbol .. not how to duplicate symbols ..

@teadrinker
Copy link
Contributor

Sorry for the confusion and hijacking of this thread.
I felt it was slightly related cos I misunderstood this issue to be about initiation of the SymbolChild...

I was curious anyway about the inner workings so I made a PR

@sense-amr
Copy link
Contributor Author

no worries man i was just saying that is what THIS issue is about .. of course feel free to make any issues you want..

@domportera
Copy link
Collaborator

Note to self:

This sounds like something that should be handled in the core editor functionality - i feel like all enums should be drop-down at all times in operators without needing to add an attribute

@pixtur
Copy link
Collaborator

pixtur commented May 12, 2024

I think this should work on dev. I tested it with [Layer2d].

However there is a crash when trying to duplicate an op with an external Enum-reference (like [AnimMockStrings] because the can't access the assembly / symbol.

@sense-amr which op doesn't work for you?

@sense-amr
Copy link
Contributor Author

sense-amr commented May 12, 2024

Ok now i tested several Ops and they do seem now to populate Enum which is great.. and as far as i know is quite new..
there is still something that doesnt seem to populate and that is the title styles .. aka the Parameter Group .. and Padding

image

image

but i am very happy to see the enums are populating ..

@pixtur
Copy link
Collaborator

pixtur commented May 15, 2024

Yes. We have to work on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that should be fixed. operator This can be solved by added a new operator. ui Task is related to user interface
Projects
Status: Done for v3.9
Development

No branches or pull requests

4 participants