Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task modification commands should trigger buffer reload #113

Open
MartyLake opened this issue Jan 5, 2017 · 7 comments
Open

Task modification commands should trigger buffer reload #113

MartyLake opened this issue Jan 5, 2017 · 7 comments
Labels
enhancement needs-decision For issues where a design decision needs to be made.

Comments

@MartyLake
Copy link
Contributor

Hi,

I had a task in Work.Reporting project, that I wanted to move to Work.Relocation. I did :TaskWikiChooseProject, selected Work.Relocation, hit . The buffer contains two view ports corresponding to these projects, the task didn't change from one viewport to the other automaticaly.

After calling : TaskWikiBufferLoad , the task move to the other viewport.

Shouldn't this be "automatic" ?

Best,

@tbabej
Copy link
Collaborator

tbabej commented Jan 6, 2017

Well, depends. It is something to be discussed.

This is not a issue that happens with TaskWikiChooseProject, but it can happen with any modification command, as the viewport filter can be anything (and not only project:myproject). So changing the behaviour to 'update the buffer after any modification command' would slow taskwiki down.

Maybe this could be configurable?

@MartyLake
Copy link
Contributor Author

MartyLake commented Jan 6, 2017 via email

@tbabej
Copy link
Collaborator

tbabej commented Jan 6, 2017

The thing is, we don't know when a buffer load is necessary. Consider this:

==== Tasks with no notes | -ANNOTATED ====
* [ ] this task has no notes

just annotating it with :TaskWikiAnnotate should make this task disappear. Hence this depends on the filter in the viewport.

@tbabej
Copy link
Collaborator

tbabej commented Jan 6, 2017

What I'm trying to say is that this feature would have potential to slow down most taskwiki commands with buffer load burden. Also, thinking some more about it, buffer load might be even something you don't want, since it would eradicate any non-saved changes (i.e. manually written X to indicate completed task).

So a more subtle approach would be needed, where, if a task inside a viewport is modified, it is rechecked whether this task still fits the viewport filter. Additionally, all the other viewport filters in the buffer would have to be considered since the task might be egligible to be removed/added there as well.

@tbabej tbabej changed the title [Improvement?] Moving task to other project should reload current buffer Task modification commands should trigger buffer reload Jul 16, 2018
@tbabej tbabej added enhancement needs-decision For issues where a design decision needs to be made. labels Jul 16, 2018
@tbabej
Copy link
Collaborator

tbabej commented Jul 16, 2018

The #176 would be also resolved by loading the buffer after a TaskWikiDone command.

@igorline
Copy link
Contributor

Will it ever be fixed? Having tasks inside vim is so good...

@tbabej
Copy link
Collaborator

tbabej commented Oct 23, 2019

@igorline Well, I could see accepting an optional feature flag to allow saving+reloading after each modification command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs-decision For issues where a design decision needs to be made.
Projects
None yet
Development

No branches or pull requests

3 participants