perf: only clear assertion _extension when overridden
#172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 859 864 +5
=====================================
+ Hits 859 864 +5 |
iamogbz
changed the title
_extension property when not overridden
iamogbz
commented
Apr 3, 2020
| ) | ||
| _executions: int = attr.ib(init=False, default=0) | ||
| _execution_results: Dict[int, "AssertionResult"] = attr.ib(init=False, factory=dict) | ||
| _post_assert_actions: List[Callable[..., None]] = attr.ib(init=False, factory=list) |
There was a problem hiding this comment.
Could use a deque but that seems like premature optimisations
iamogbz
changed the title
_extension property when not overridden_extension when overridden
noahnu
reviewed
Apr 3, 2020
| @@ -51,5 +51,6 @@ def test_multiple_snapshot_extensions(snapshot): | |||
| """ | |||
| assert actual_svg == snapshot(extension_class=SVGImageSnapshotExtension) | |||
| assert actual_svg == snapshot # uses initial extension class | |||
| assert snapshot._extension is not None | |||
There was a problem hiding this comment.
This is testing internals. Is there a user facing test?
There was a problem hiding this comment.
There's no user effect only that slight performance drawback of generating the extension instance on each assertion
There was a problem hiding this comment.
Bit concerned about coupling the internal implementation with the test cases, but am okay with this as a temporary measure until we have perf benchmarking
noahnu
approved these changes
Apr 3, 2020
syrupy-bot
pushed a commit
that referenced
this pull request
Apr 3, 2020
## [0.3.8](v0.3.7...v0.3.8) (2020-04-03) ### Performance Improvements * only clear assertion `_extension` when overridden ([#172](#172)) ([82eae91](82eae91))
|
🎉 This PR is included in version 0.3.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_extensionproperty cache is always clearedRelated Issues
N/A
Checklist
Additional Comments