Fix getting JSON response for 204 status code (#53)

toptal · Jun 4, 2024 · f7fd387 · f7fd387
1 parent 7c7269c
commit f7fd387
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/slack/src/request.ts b/packages/slack/src/request.ts
@@ -22,6 +22,11 @@ function sanitizeTimeout(timeout) {
     return undefined
 }
 
+function getJSON(response) {
+    if (response.status === 204) return {};
+    return response.json();
+}
+
 class BadStatusCodeError extends Error {
     statusCode: number
     response: any
@@ -68,7 +73,7 @@ async function request(method, { uri, headers, body, form, json, timeout }): Pro
         if (response.status >= 400) {
             throw new BadStatusCodeError(response)
         }
-        return json ? response.json() : response
+        return json ? getJSON(response) : response
     }
     catch (err) {
         if (err.name === 'AbortError') {