Any reason why INSTALL_BIN_SUBDIR is set to . on windows?

[hughperkins]

• on windows, my share directory is located directly under $TORCH, rather than in $TORCH/install
• it turns out this is because this directory is determined by $LUA_BINDIR
• and this comes from the rockspec commandline
• which ultimately comes from the luarocks config file
• which comes from ....

  luajit-rocks/luarocks/CMakeLists.txt

  Lines 7 to 22 in 411f4b9

  	IF(WIN32)
  	SET(INSTALL_BIN_SUBDIR "." CACHE STRING "installation executable subdirectory name")
  	SET(INSTALL_LIB_SUBDIR "." CACHE STRING "installation library subdirectory name")
  	SET(INSTALL_LUA_PATH_SUBDIR "lua") # not editable
  	SET(INSTALL_LUA_CPATH_SUBDIR ".") # not editable
  	SET(INSTALL_LUAROCKS_ROCKS_SUBDIR "luarocks" CACHE STRING "installation luarocks rocks subdirectory name")
  	SET(INSTALL_LUAROCKS_SYSCONF_SUBDIR "luarocks" CACHE STRING "installation luarocks sysconfig subdirectory name")
  	ELSE()
  	SET(INSTALL_BIN_SUBDIR "bin" CACHE STRING "installation executable subdirectory name")
  	SET(INSTALL_LIB_SUBDIR "lib" CACHE STRING "installation library subdirectory name")
  	SET(INSTALL_LUA_PATH_SUBDIR "share/lua/${LUA_VERSION}") # not editable
  	SET(INSTALL_LUA_LIB_SUBDIR "lib" CACHE STRING "installation lua lib subdirectory name")
  	SET(INSTALL_LUA_CPATH_SUBDIR "${INSTALL_LUA_LIB_SUBDIR}/lua/${LUA_VERSION}") # not editable
  	SET(INSTALL_LUAROCKS_ROCKS_SUBDIR "lib/luarocks/rocks" CACHE STRING "installation luarocks rocks subdirectory name")
  	SET(INSTALL_LUAROCKS_SYSCONF_SUBDIR "etc/luarocks" CACHE STRING "installation luarocks sysconfig subdirectory name")
  	ENDIF()

IF(WIN32)
  SET(INSTALL_BIN_SUBDIR "." CACHE STRING "installation executable subdirectory name")
  SET(INSTALL_LIB_SUBDIR "." CACHE STRING "installation library subdirectory name")
  SET(INSTALL_LUA_PATH_SUBDIR "lua") # not editable
  SET(INSTALL_LUA_CPATH_SUBDIR ".") # not editable
  SET(INSTALL_LUAROCKS_ROCKS_SUBDIR "luarocks" CACHE STRING "installation luarocks rocks subdirectory name")
  SET(INSTALL_LUAROCKS_SYSCONF_SUBDIR "luarocks" CACHE STRING "installation luarocks sysconfig subdirectory name")
ELSE()
  SET(INSTALL_BIN_SUBDIR "bin" CACHE STRING "installation executable subdirectory name")
  SET(INSTALL_LIB_SUBDIR "lib" CACHE STRING "installation library subdirectory name")
  SET(INSTALL_LUA_PATH_SUBDIR "share/lua/${LUA_VERSION}") # not editable
  SET(INSTALL_LUA_LIB_SUBDIR "lib" CACHE STRING "installation lua lib subdirectory name")
  SET(INSTALL_LUA_CPATH_SUBDIR "${INSTALL_LUA_LIB_SUBDIR}/lua/${LUA_VERSION}") # not editable
  SET(INSTALL_LUAROCKS_ROCKS_SUBDIR "lib/luarocks/rocks" CACHE STRING "installation luarocks rocks subdirectory name")
  SET(INSTALL_LUAROCKS_SYSCONF_SUBDIR "etc/luarocks" CACHE STRING "installation luarocks sysconfig subdirectory name")
ENDIF()

Seems like on purpose LUA_BINDIR is set to . rather than bin on Windows. Before I change this, it seems highly likely this change was done on purpose, so I'm wondering ... why? what are the consequences of making it uniform to the linux version?

[soumith]

go ahead and change it. what's the worst that can happen. i dont know why it was originally like this.