Change the JSON response for torrent details

[josecelano]

The current response is:

{
    "data": {
        "torrent_id": 2651,
        "uploader": "admin",
        "info_hash": "4fe4da4ab81399e7b167d8c2928fd3e28659b6ef",
        "title": "con un comentario",
        "description": "con un comentario",
        "category": {
            "category_id": 63,
            "name": "Paper",
            "num_torrents": 1195
        },
        "upload_date": "2023-09-18 10:25:21",
        "file_size": 13,
        "seeders": 0,
        "leechers": 0,
        "files": [
            {
                "path": [
                    "example.txt"
                ],
                "length": 13,
                "md5sum": null
            }
        ],
        "trackers": [
            "udp://localhost:6969",
            "udp://localhost:6969"
        ],
        "magnet_link": "magnet:?xt=urn:btih:4fe4da4ab81399e7b167d8c2928fd3e28659b6ef&dn=con%20un%20comentario&tr=udp%3A%2F%2Flocalhost%3A6969&tr=udp%3A%2F%2Flocalhost%3A6969",
        "tags": [
            {
                "tag_id": 1,
                "name": "tag1_1"
            }
        ],
        "name": "example.txt"
    }
}

I would change it to:

{
    "data": {
        "torrent_id": 2651,
        "uploader": "admin",
        "info_hash": "4fe4da4ab81399e7b167d8c2928fd3e28659b6ef",
        "upload_date": "2023-09-18 10:25:21",
        "metadata": {
            "title": "con un comentario",
            "description": "con un comentario",
            "category": {
                "category_id": 63,
                "name": "Paper",
                "num_torrents": 1195
            },
            "tags": [
                {
                    "tag_id": 1,
                    "name": "tag1_1"
                }
            ]
        },
        "metainfo": {
            "info": {
                "name": "example.txt",
                "file_size": 13,
                "files": [
                    {
                        "path": [
                            "example.txt"
                        ],
                        "length": 13,
                        "md5sum": null
                    }
                ]
            },
            "trackers": [
                "udp://localhost:6969",
                "udp://localhost:6969"
            ],
            "magnet_link": "magnet:?xt=urn:btih:4fe4da4ab81399e7b167d8c2928fd3e28659b6ef&dn=con%20un%20comentario&tr=udp%3A%2F%2Flocalhost%3A6969&tr=udp%3A%2F%2Flocalhost%3A6969"
        }
        "statistics": {
            "seeders": 0,
            "leechers": 0,
        }
    }
}

Parts:

• Internal index data: torrent_id, uploader, info_hash, upload_date.
• Metadata: torrent classification fields. Defined by the user.
• Metainfo: the torrent file.
• Statistics: the current and other future statistics.

The essential thing would be to differentiate between the torrent file info and the rest of the fields. And for the torrent file, I would follow the same structure used by torrent files. I mean:

{
   "announce": "udp://localhost:6969",
   "announce-list": [
      [
         "udp://localhost:6969"
      ]
   ],
   "info": {
      "length": 13,
      "name": "example.txt",
      "piece length": 16384,
      "pieces": "<hex>A0 B6 59 39 67 0B C2 C0 10 F4 D5 D6 A0 B3 E4 E4 59 0F B9 2B</hex>"
   }
}

cc @da2ce7 @mario-nt

[mario-nt]

I agree and I think this is a really good change, as it reflects the BitTorrent specification better, and helps make the project look more "profesional".

Also, and maybe even more important, it makes any debugging of the response easier and clearer.