Idea: Preventing Inappropriate Service Invocation

[cjwcommuny]

The Service trait requires users to call poll_ready before invoking the call function in order to check if the service is ready or not. However, users are not obligated to do this and may forget to call poll_ready.

Therefore, it is worth considering whether it would be beneficial to use the type system to prevent users from invoking call if the service is not ready.

One suggestion is to introduce a ready token with type Service::Ready as follows:

pub trait Service<Request> {
    type Response;
    type Error;
    type Future: Future<Output = Result<Self::Response, Self::Error>>;
    type Ready;

    fn poll_ready(
        &mut self,
        cx: &mut Context<'_>
    ) -> Poll<Result<Self::Ready, Self::Error>>;

    fn call(&mut self, token: Self::Ready, req: Request) -> Self::Future;
}

With this approach, users must obtain a token: Self::Ready before invoking call, which can only be extracted from Poll::Ready(Ok(Self::Ready)). This follows the "Parse, not validate" paradigm.

Incorporating the ready token in the implementation of Service would help eliminate the need for checking the invalid state that may occur while invoking call:

tower/tower/src/limit/rate/service.rs

Line 116 in 664cb35

State::Limited => panic!("service not ready; poll_ready must be called first"),

[davidpdrsn]

This has been discussed before. See

• Is poll_ready worth it? #626
• Make poll_ready() return a token which call() consumes #412
• Disarming Service after successful poll_ready #408