Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most Viewed/Visited sorts in the wrong direction #46

Closed
goaround opened this issue Dec 26, 2022 · 6 comments
Closed

Most Viewed/Visited sorts in the wrong direction #46

goaround opened this issue Dec 26, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@goaround
Copy link

If you sort the keywords in the Tracking tab, Most Viewed/Visited is sorts asc but should be desc

See:

sortOptionChoices.push({ value: 'imp_asc', label: `Most Viewed${isConsole ? ' (Default)' : ''}` });

@goaround
Copy link
Author

Top Position and Lowest Position sorts in the wrong direction, too.

@towfiqi
Copy link
Owner

towfiqi commented Jan 9, 2023

@goaround Just checked, and both works fine. Since the lower the position, the better it is, Top position sort displays the lowest ranks first.

@ghost
Copy link

ghost commented Jan 10, 2023

Yes, but in the tracker view its the opposite. They both should sort under the same idea.

@towfiqi
Copy link
Owner

towfiqi commented Jan 10, 2023

Just checked, the Console View actually has the buggy behavior. Will fix in next release.

@goaround
Copy link
Author

Tracking Top Position and Lowest Position sort are also wrong:

UjXaIWm9

@towfiqi
Copy link
Owner

towfiqi commented Jan 10, 2023

@goaround Thanks for that. Not sure how I missed it..

@towfiqi towfiqi added the bug Something isn't working label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants