Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to v2 addon #223

Closed
SergeAstapov opened this issue Mar 15, 2022 · 2 comments
Closed

Convert to v2 addon #223

SergeAstapov opened this issue Mar 15, 2022 · 2 comments

Comments

@SergeAstapov
Copy link
Contributor

As this addon provides only run-time functionality hence it's the great candidate for v2 addon conversion.

This would require major release.

@chriskrycho any thoughts, concerns?

@chriskrycho
Copy link
Collaborator

In general, I’m strongly in support. My main hesitation is timing: we just cut a major fairly recently, and folks have had issues because there's a coordination challenge with this, tracked-built-ins, and tracked-toolbox. My current thinking is: it's totally fine to go ahead and do, and we can even cut a beta for the next major, but we should wait to major until we drop Node 12 support when it goes out of LTS support at the end of April. Feel free to knock this out and we can get the beta out to unblock people!

@chriskrycho
Copy link
Collaborator

Per tracked-tools/tracked-built-ins#274 (comment), let's actually not do this and resolve it by way of pulling this functionality entirely into tracked-built-ins (as part of the implementation prep work to unblock whatever iteration on emberjs/rfcs#812 we end up merging!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants