Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netflow values are always positive #652

Open
kenkunz opened this issue Oct 30, 2023 · 0 comments
Open

Netflow values are always positive #652

kenkunz opened this issue Oct 30, 2023 · 0 comments
Assignees
Labels
bug Something isn't working priority: P1 An important issue that must be fixed before the next release, but does nto require immediate focus. size: S A small task that can be completed in less than a day

Comments

@kenkunz
Copy link

kenkunz commented Oct 30, 2023

Issue

The data returned by chart?type=netflow endpoint is always positive. Deposit values should be positive, withdrawal values should be negative.

Steps to reproduce

The following steps could be reproduced with any live Enzyme-based strategy. The example below uses MATIC-USD breakout on Uniswap v3.

  1. Open strategy overview page
  2. Make a deposit; make note of the time and amount of USDC deposited (e.g., 2.0 USDC)
  3. Make a withdrawal (using a different amount than in step 2); make note of the time and amount of USDC withdrawn (e.g., 1.07 USDC)
  4. Wait a bit for the trade-executor chart data to reflect the updates
  5. Request the netflow chart data for the strategy:
    curl https://enzyme-polygon-matic-usdc.tradingstrategy.ai/chart?type=netflow&source=live_trading | jq
  6. Note the deposit and withdrawal values at the end of the data array
    • expected: deposit is positive value; withdrawal is negative
    • actual: deposit and withdrawal are both positive
@kenkunz kenkunz added bug Something isn't working priority: P1 An important issue that must be fixed before the next release, but does nto require immediate focus. size: S A small task that can be completed in less than a day labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: P1 An important issue that must be fixed before the next release, but does nto require immediate focus. size: S A small task that can be completed in less than a day
Projects
None yet
Development

No branches or pull requests

2 participants