New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in-kind redemptions fix for realised PnL #665

Merged

miohtama merged 4 commits into master from fix-profit-calculation-redemption

Nov 20, 2023

Collaborator

miohtama commented Nov 20, 2023 •

edited

Loading

Fix realised PnL calculation in the case spot positions contain in-kind redemptions
Allow mixing str and Path in state serialisation
Change hash() for TradingPairIdentifier to be independent from the internal id. Hash together (base, quote, fee) like Uniswap v3 does.

miohtama added 4 commits

November 20, 2023 20:45


          Adding in-kind redemptions fix for realised PnL

4b9cd09


          Realise profit w/redemption test pass

1d4945e


          Fix changed strat file name

9fde5a3


          Rerun realised PnL analysis notebook

miohtama merged commit 02167f6 into master

5 checks passed

Contributor

AlexTheLion123 commented Nov 21, 2023

fixes #663

AlexTheLion123 linked an issue

that may be closed by this pull request

incorrect profit on frontend 2 #663

Open

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet