Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin titles are sometimes configured through options, something in locale #5018

Closed
2 tasks done
Tracked by #4764
Murderlon opened this issue Mar 25, 2024 · 1 comment
Closed
2 tasks done
Tracked by #4764
Labels
4.0 For the 4.0 major version Bug

Comments

@Murderlon
Copy link
Member

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

For instance Url:

this.title = this.opts.title || 'Link'

But others like Zoom do this via locale:

this.title = this.i18n('pluginNameZoom')

Expected behavior

If I remember correctly, it was decided that locale should be the place for this and thus we should migrate over the other plugins.

Actual behavior

Inconsistency.

@Murderlon Murderlon added Bug 4.0 For the 4.0 major version labels Mar 25, 2024
@aduh95
Copy link
Contributor

aduh95 commented Jul 11, 2024

Fixed by #5134

@aduh95 aduh95 closed this as completed Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 For the 4.0 major version Bug
Projects
None yet
Development

No branches or pull requests

2 participants