Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shuffle the config loading to make it available earlier #311

Closed
vkatsuba opened this issue Jan 29, 2021 · 0 comments · Fixed by #310
Closed

Shuffle the config loading to make it available earlier #311

vkatsuba opened this issue Jan 29, 2021 · 0 comments · Fixed by #310
Labels
improvement 💡 Improvement

Comments

@vkatsuba
Copy link
Contributor

erGW version

2.8.5

Description

Our configuration loading and checking always had problems with when to load and apply what. This reshuffle the part to separate configuration validation and the actual application of the handler and socket config.

Current behavior

The configuration loading and checking occurs after initialization of some components.

Expected behavior

The configuration loading and checking should happen before starting and initializing components.
@vkatsuba vkatsuba added the improvement 💡 Improvement label Jan 29, 2021
@vkatsuba vkatsuba linked a pull request Jan 29, 2021 that will close this issue
Shuffle the config loading to make it available earlier #310
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement 💡 Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shuffle the config loading to make it available earlier travelping/ergw
1 participant
@vkatsuba