Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Make a clear distrinction between streaming and package based connectors #167

Open
Licenser opened this issue Jun 24, 2021 · 9 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@Licenser
Copy link
Member

Describe the problem you are trying to solve

Some of our connectors are package based where one chunk of data == one event, udp, kafka, HTTP, WS are some examples.

Others are stream based where there is no alignment to event boundaries, TCP and file are examples. Those usually require a preprocessor and postprocessor to add framing.

We do not make it clear in the documentation which connector behaves which way and has which guarantees, that can lead to confusion.

We should be clearer about this.

@Licenser Licenser added the enhancement New feature or request label Jun 24, 2021
@afzal442
Copy link

Hi @Licenser, I want to look into it!

@skoech
Copy link

skoech commented Jul 28, 2021

Hello @afzal442! Welcome to Tremor!
We are happy you want to contribute. How would you like to go about this?

@afzal442
Copy link

Thanks @skoech! I wondered which doc's part for this issue needs to be fixed.

@skoech
Copy link

skoech commented Jul 28, 2021

We would need to update the docs of all the connectors (onramps/offramps).

@skoech
Copy link

skoech commented Jul 28, 2021

So, TCP is stream-based while the rest are all packet-based.

@afzal442
Copy link

Makes sense. I found those links as https://github.com/tremor-rs/tremor-www-docs/blob/main/docs/artefacts/offramps&onramps.md . Any next suggestions?

@skoech
Copy link

skoech commented Jul 29, 2021

Yes, good. :)
Then maybe create your own fork to work on, if you haven't yet?

@afzal442
Copy link

Hy @skoech, your discord handle plz?

@skoech
Copy link

skoech commented Jul 29, 2021

I'm shay#4695. I already reached out to you. Sorry I didn't mention it was me. 😀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants